jcsherin commented on PR #16839: URL: https://github.com/apache/datafusion/pull/16839#issuecomment-3097357784
I've confirmed the URLs you fixed were returning 404. I used the [lychee cli link checker](https://lychee.cli.rs/) which flagged them with a `404 Not Found` error. Unlike `cargo-deadlinks`, lychee works on the generated Rust docs in `target/doc` directory and cannot directly inspect the Rust code. It also flagged two URLs in `sqlparser` crate. 1. https://docs.rs/sqlparser/latest/src/sqlparser/dialect/duckdb.rs.html#68 ```rust /// See <https://duckdb.org/docs/sql/functions/lambda.html> fn supports_lambda_functions(&self) -> bool { true } ``` Fix: https://duckdb.org/docs/stable/sql/functions/lambda 2. https://docs.rs/sqlparser/latest/src/sqlparser/ast/ddl.rs.html#149 ```rust /// `ATTACH PART|PARTITION <partition_expr>` /// Note: this is a ClickHouse-specific operation, please refer to /// [ClickHouse](https://clickhouse.com/docs/en/sql-reference/statements/alter/pakrtition#attach-partitionpart) AttachPartition { // PART is not a short form of PARTITION, it's a separate keyword // which represents a physical file on disk and partition is a logical entity. partition: Partition, }, ``` Fix: https://clickhouse.com/docs/sql-reference/statements/alter/partition#attach-partitionpart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
