berkaysynnada commented on PR #16745: URL: https://github.com/apache/datafusion/pull/16745#issuecomment-3105944943
Hi again @liamzwbao. We’ve discussed this with @ozankabak, and the actual fix should be on the `PartialOrd` implementation of ScalarValue of floats. The comparison currently uses `total_ord`, but I don’t think there’s a valid reason for that. We should revert it to use `partial_ord` instead. After that, the interval_arithmetic code won’t need any modifications -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
