parthchandra commented on code in PR #2032: URL: https://github.com/apache/datafusion-comet/pull/2032#discussion_r2226136383
########## common/src/main/java/org/apache/comet/parquet/BatchReader.java: ########## @@ -143,7 +143,9 @@ public class BatchReader extends RecordReader<Void, ColumnarBatch> implements Cl private boolean useLegacyDateTimestamp; /** The TaskContext object for executing this task. */ - private final TaskContext taskContext; + protected TaskContext taskContext; Review Comment: This does not need to be protected. It's not used by the derived class (and it is specifically for testing). (It can also be initialized in the default constructor if one really needs it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
