iffyio commented on code in PR #1968:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1968#discussion_r2226163647
##########
tests/sqlparser_common.rs:
##########
@@ -16256,3 +16256,25 @@ fn parse_notnull() {
// for unsupported dialects, parsing should stop at `NOT NULL`
notnull_unsupported_dialects.expr_parses_to("NOT NULL NOTNULL", "NOT
NULL");
}
+
+#[test]
+fn pares_copy_options() {
Review Comment:
```suggestion
fn parse_copy_options() {
```
##########
tests/sqlparser_common.rs:
##########
@@ -16256,3 +16256,25 @@ fn parse_notnull() {
// for unsupported dialects, parsing should stop at `NOT NULL`
notnull_unsupported_dialects.expr_parses_to("NOT NULL NOTNULL", "NOT
NULL");
}
+
+#[test]
+fn pares_copy_options() {
+ let copy = verified_stmt(
+ r#"COPY dst (c1, c2, c3) FROM
's3://redshift-downloads/tickit/category_pipe.txt' IAM_ROLE
'arn:aws:iam::123456789:role/role1' CSV IGNOREHEADER 1"#,
Review Comment:
Can we add tests to cover the `IAM ROLE DEFAULT` and `CSV IGNOREHEADER AS
...` scenarios?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
