ding-young commented on code in PR #15700:
URL: https://github.com/apache/datafusion/pull/15700#discussion_r2227210285
##########
datafusion/physical-plan/src/spill/spill_manager.rs:
##########
@@ -140,3 +210,19 @@ impl SpillManager {
Ok(spawn_buffered(stream, self.batch_read_buffer_capacity))
}
}
+
+pub(crate) trait GetSlicedSize {
+ /// Returns the size of the `RecordBatch` when sliced.
+ fn get_sliced_size(&self) -> usize;
+}
+
+impl GetSlicedSize for RecordBatch {
+ fn get_sliced_size(&self) -> usize {
+ let mut total = 0;
+ for array in self.columns() {
+ let data = array.to_data();
+ total += data.get_slice_memory_size().unwrap();
+ }
+ total
Review Comment:
Thanks for applying the suggestion! Let's return `Result<usize>` instead of
calling `unwrap()`. Since we already support `From<ArrowError> for
DataFusionError`, we can simply propagate the error using ?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
