zhuqi-lucas commented on code in PR #16885:
URL: https://github.com/apache/datafusion/pull/16885#discussion_r2228057786


##########
datafusion/spark/src/function/math/hex.rs:
##########
@@ -212,6 +215,16 @@ pub fn compute_hex(
 
                 Ok(ColumnarValue::Array(Arc::new(hexed)))
             }
+            DataType::Utf8View => {
+                let array = as_string_view_array(array)?;
+
+                let hexed: StringArray = array

Review Comment:
   Thanks @xudong963 , a minor question:
   
   Here hexed is StringArray, why not using StringViewArray? Is it because we 
don't support it for the usage for this function?
   
   It looks like the upper level spark don't support utf8view?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to