alamb commented on code in PR #16901:
URL: https://github.com/apache/datafusion/pull/16901#discussion_r2229318658


##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -706,28 +706,6 @@ impl FileScanConfig {
         }
     }
 
-    /// Set the file source
-    #[deprecated(since = "47.0.0", note = "use FileScanConfigBuilder instead")]

Review Comment:
   Technically speaking we should leave these methods until 53.0.0 per 
https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines
   
   
   However, given they are pretty low level (and thus I don't expect many 
actual users of them) and we are trying to work on this code for other reasons, 
I think it is fine to remove them early



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to