berkaysynnada commented on code in PR #16897:
URL: https://github.com/apache/datafusion/pull/16897#discussion_r2230787048
##########
datafusion/physical-expr/src/window/window_expr.rs:
##########
@@ -130,6 +130,12 @@ pub trait WindowExpr: Send + Sync + Debug {
/// Get the reverse expression of this [WindowExpr].
fn get_reverse_expr(&self) -> Option<Arc<dyn WindowExpr>>;
+ /// Creates a new instance of the window function evaluator.
Review Comment:
Yes, this util becomes useful when updating WindowAggState's from
deserialized window_fn states. If it seems too specific, I can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
