avantgardnerio commented on code in PR #16972:
URL: https://github.com/apache/datafusion/pull/16972#discussion_r2243767844
##########
datafusion/physical-plan/src/aggregates/topk/hash_table.rs:
##########
@@ -433,8 +440,27 @@ pub fn new_hash_table(
#[cfg(test)]
mod tests {
use super::*;
+ use arrow::array::TimestampMillisecondArray;
+ use arrow_schema::TimeUnit;
use std::collections::BTreeMap;
+ #[test]
+ fn should_emit_correct_type() -> Result<()> {
Review Comment:
Thanks. I started with @niebayes ' test and created this one instead because
it covered the case and felt less like an e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
