zhuqi-lucas commented on PR #16690:
URL: https://github.com/apache/datafusion/pull/16690#issuecomment-3138367838

   > ๐Ÿค–: Benchmark completed
   > 
   > Details
   > 
   > ```
   > Comparing HEAD and alamb_update_arrow_56.0.0
   > --------------------
   > Benchmark sort_tpch1.json
   > --------------------
   > โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   > โ”ƒ Query        โ”ƒ       HEAD โ”ƒ alamb_update_arrow_56.0 โ”ƒ        Change โ”ƒ
   > โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   > โ”‚ Q1           โ”‚  349.61 ms โ”‚               323.45 ms โ”‚ +1.08x faster โ”‚
   > โ”‚ Q2           โ”‚  308.94 ms โ”‚               317.36 ms โ”‚     no change โ”‚
   > โ”‚ Q3           โ”‚ 1112.50 ms โ”‚              1014.45 ms โ”‚ +1.10x faster โ”‚
   > โ”‚ Q4           โ”‚  437.16 ms โ”‚               431.15 ms โ”‚     no change โ”‚
   > โ”‚ Q5           โ”‚  418.20 ms โ”‚               416.31 ms โ”‚     no change โ”‚
   > โ”‚ Q6           โ”‚  459.93 ms โ”‚               453.85 ms โ”‚     no change โ”‚
   > โ”‚ Q7           โ”‚  817.52 ms โ”‚               817.33 ms โ”‚     no change โ”‚
   > โ”‚ Q8           โ”‚  705.87 ms โ”‚               698.17 ms โ”‚     no change โ”‚
   > โ”‚ Q9           โ”‚  734.30 ms โ”‚               724.44 ms โ”‚     no change โ”‚
   > โ”‚ Q10          โ”‚ 1084.13 ms โ”‚              1057.24 ms โ”‚     no change โ”‚
   > โ”‚ Q11          โ”‚  569.35 ms โ”‚               552.48 ms โ”‚     no change โ”‚
   > โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   > โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   > โ”ƒ Benchmark Summary                      โ”ƒ           โ”ƒ
   > โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   > โ”‚ Total Time (HEAD)                      โ”‚ 6997.49ms โ”‚
   > โ”‚ Total Time (alamb_update_arrow_56.0)   โ”‚ 6806.22ms โ”‚
   > โ”‚ Average Time (HEAD)                    โ”‚  636.14ms โ”‚
   > โ”‚ Average Time (alamb_update_arrow_56.0) โ”‚  618.75ms โ”‚
   > โ”‚ Queries Faster                         โ”‚         2 โ”‚
   > โ”‚ Queries Slower                         โ”‚         0 โ”‚
   > โ”‚ Queries with No Change                 โ”‚         9 โ”‚
   > โ”‚ Queries with Failure                   โ”‚         0 โ”‚
   > โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   > ```
   
   Thank you @alamb the result is very good, we have further improvement for 
sort also besides the ported code in datafusion, even Q1 is benefit which is 
not StringView sort from the new partition null validation, and Q3 is benefit 
from the new GC for large buffer size. And the sort-tpch10 seems broken. ๐Ÿค”
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to