adriangb commented on code in PR #16445:
URL: https://github.com/apache/datafusion/pull/16445#discussion_r2245195106
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1039,12 +1196,50 @@ async fn collect_left_input(
let data = JoinLeftData::new(
hashmap,
single_batch,
- left_values,
+ left_values.clone(),
Mutex::new(visited_indices_bitmap),
AtomicUsize::new(probe_threads_count),
reservation,
);
+ // Update dynamic filter with min/max bounds if provided
+ if num_rows > 0 {
Review Comment:
If it's easy to pipe through sounds good, but in my mind
`enable_dynamic_filter_pushdown` is more for us debugging as we've been adding
these dynamic filters / proving equivalence of query results more so than an
option users would toggle on or off -> it's not a big deal if some work is done
even if the flag is off. Our goal should be that the extra work done for
dynamic filters is always cheap enough that it does't make queries slower even
if the flag is off but the work is done anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
