iffyio commented on code in PR #1969:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1969#discussion_r2247611535
##########
src/parser/mod.rs:
##########
@@ -10810,6 +10810,16 @@ impl<'a> Parser<'a> {
}
}
+ pub fn parse_parenthesized_columns_with_alias_list(
+ &mut self,
+ optional: IsOptional,
+ allow_empty: bool,
+ ) -> Result<Vec<ExprWithAlias>, ParserError> {
+ self.parse_parenthesized_column_list_inner(optional, allow_empty, |p| {
+ p.parse_expr_with_alias()
+ })
Review Comment:
Can we inline this function since its only a couple lines and used once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
