zhuqi-lucas commented on code in PR #16445: URL: https://github.com/apache/datafusion/pull/16445#discussion_r2247959415
########## datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs: ########## @@ -734,6 +734,366 @@ async fn test_topk_dynamic_filter_pushdown() { ); } +#[tokio::test] +async fn test_hashjoin_dynamic_filter_pushdown() { + use datafusion_common::JoinType; + use datafusion_physical_plan::joins::{HashJoinExec, PartitionMode}; + + // Create build side with limited values + let build_batches = vec![record_batch!( + ("a", Utf8, ["aa", "ab"]), + ("b", Utf8, ["ba", "bb"]), Review Comment: We may add some Utf8View fields testing cases, because our default mapping already changing to Utf8View. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org