adriangb commented on code in PR #16445:
URL: https://github.com/apache/datafusion/pull/16445#discussion_r2260557873
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -966,8 +1005,33 @@ impl ExecutionPlan for HashJoinExec {
&self.children(),
));
}
- FilterDescription::from_children(parent_filters, &self.children())
- // TODO: push down our self filters to children in the post
optimization phase
+
+ // Get basic filter descriptions for both children
+ let mut left_child =
crate::filter_pushdown::ChildFilterDescription::from_child(
+ &parent_filters,
+ self.left(),
+ )?;
+ let mut right_child =
crate::filter_pushdown::ChildFilterDescription::from_child(
+ &parent_filters,
+ self.right(),
+ )?;
+
+ // Add dynamic filters in Post phase if enabled
+ if matches!(phase, FilterPushdownPhase::Post)
+ && config.optimizer.enable_dynamic_filter_pushdown
+ {
+ // Add placeholder to left side (build side)
+ left_child = left_child.with_self_filter(lit(true));
Review Comment:
You're right I don't think it is, not sure why I / Claude put that in there!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
