alamb opened a new pull request, #17019:
URL: https://github.com/apache/datafusion/pull/17019

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   I suggested using dev containers on this PR
   https://github.com/apache/datafusion/pull/17018#issuecomment-3146420097
   
   <img width="1343" height="717" alt="Screenshot 2025-08-02 at 6 22 00 AM" 
src="https://github.com/user-attachments/assets/2c0ba5e2-651e-47cd-a12c-4f8b07c76932";
 />
   
   
   However, when I actually tried to use it, I got an error about npm not being 
installed (see screenshot):
   
   <img width="1701" height="1041" alt="Screenshot 2025-08-02 at 6 41 21 AM" 
src="https://github.com/user-attachments/assets/882bacc4-7159-4ab5-ac50-deec78a08ffa";
 />
   
   ```shell
   root@codespaces-09a5ab:/workspaces/datafusion# ./dev/update_function_docs.sh
   /workspaces/datafusion
   Inserting header
   Running CLI and inserting aggregate function docs table
       Updating crates.io index
       Blocking waiting for file lock on package cache
       Blocking waiting for file lock on package cache
       ...
   
      Compiling datafusion v49.0.0 (/workspaces/datafusion/datafusion/core)
       Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 59s
        Running `target/debug/print_functions_docs aggregate`
   Running prettier
   ./dev/update_function_docs.sh: line 68: npx: command not found
   root@codespaces-09a5ab:/workspaces/datafusion# apt-get install npm
   Reading package lists... Done
   Building dependency tree... Done
   Reading state information... Done
   E: Unable to locate package npm
   ```
   
   
   ## What changes are included in this PR?
   
   1. Add nodejs, npm to the dev container
   2. Pre-install prettier
   
   ## Are these changes tested?
   
   I am testing them manually
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to