xtuc commented on code in PR #1991:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1991#discussion_r2254178645
##########
tests/sqlparser_sqlite.rs:
##########
@@ -592,6 +593,41 @@ fn test_regexp_operator() {
sqlite().verified_only_select(r#"SELECT count(*) FROM messages WHERE
msg_text REGEXP '\d+'"#);
}
+#[test]
+fn test_update_delete_limit() {
Review Comment:
I need a new dialect that returns has supports_update_delete_limit.
Unfortunately if we add parameters to `SQLiteDialect {}` it will be a
breaking change. I think it would be better though.
##########
tests/sqlparser_sqlite.rs:
##########
@@ -592,6 +593,41 @@ fn test_regexp_operator() {
sqlite().verified_only_select(r#"SELECT count(*) FROM messages WHERE
msg_text REGEXP '\d+'"#);
}
+#[test]
+fn test_update_delete_limit() {
Review Comment:
I need a new dialect that has supports_update_delete_limit.
Unfortunately if we add parameters to `SQLiteDialect {}` it will be a
breaking change. I think it would be better though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
