xtuc commented on code in PR #1991:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1991#discussion_r2254189696
##########
src/parser/mod.rs:
##########
@@ -15116,13 +15116,20 @@ impl<'a> Parser<'a> {
} else {
None
};
+ let limit =
+ if self.dialect.supports_update_delete_limit() &&
self.parse_keyword(Keyword::LIMIT) {
+ Some(self.parse_expr()?)
+ } else {
+ None
+ };
Review Comment:
Yeah that would simplify things. It means that sqlparser can accept a
statement and sqlite won't (since `update ... limit ...` is behind a
compilation flag). I though it would be better for the user to configure it,
but up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
