adriangb commented on code in PR #17056: URL: https://github.com/apache/datafusion/pull/17056#discussion_r2257951256
########## datafusion/physical-expr/src/expressions/is_not_null.rs: ########## @@ -94,10 +93,6 @@ impl PhysicalExpr for IsNotNullExpr { } } - fn return_field(&self, input_schema: &Schema) -> Result<FieldRef> { - self.arg.return_field(input_schema) - } Review Comment: This makes sense, `is_null` always returns a non-nullable boolean, it does not depend on the input. The default implementation looks like: https://github.com/apache/datafusion/blob/73b50536570cbf87f95bbebd4952b8017dfe25b6/datafusion/physical-expr-common/src/physical_expr.rs#L86-L92 Which is exactly what we want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org