adriangb commented on code in PR #17056: URL: https://github.com/apache/datafusion/pull/17056#discussion_r2256990158
########## datafusion/sqllogictest/test_files/expr.slt: ########## @@ -2131,3 +2131,18 @@ query T select E'foo\t\tbar'; ---- foo bar + +statement ok +create table t (a float) as values (1), (2), (3); Review Comment: ```suggestion create table t (a float) as values (1), (null), (3); ``` ########## datafusion/sqllogictest/test_files/expr.slt: ########## @@ -2131,3 +2131,18 @@ query T select E'foo\t\tbar'; ---- foo bar + +statement ok +create table t (a float) as values (1), (2), (3); + +# https://github.com/apache/datafusion/issues/17055 +# is not null did not correctly infer as boolean in udf argument position +query B +select greatest(a is not null, false) from t; +---- +true +true Review Comment: ```suggestion false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
