findepi opened a new issue, #17064: URL: https://github.com/apache/datafusion/issues/17064
`PartialOrd` implementation for `ScalarUDF`, `WindowUDF` and `AggregateUDF` compares name and signature only. `PartialEq` implementation for these structs delegates to the function implementation and thus may compare other properties. the contract for these traits is (https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html): > `a == b` if and only if `partial_cmp(a, b) == Some(Equal)`. > [...] thus the contract is violated We should remove these incorrect `PartialOrd` implementations. - relates to https://github.com/apache/datafusion/issues/16677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
