andygrove commented on code in PR #2122:
URL: https://github.com/apache/datafusion-comet/pull/2122#discussion_r2267651792
##########
spark/src/main/java/org/apache/spark/shuffle/comet/CometBoundedShuffleMemoryAllocator.java:
##########
@@ -147,7 +147,8 @@ private synchronized MemoryBlock allocateMemoryBlock(long
required) {
}
public synchronized void free(MemoryBlock block) {
- if (block.pageNumber == MemoryBlock.FREED_IN_ALLOCATOR_PAGE_NUMBER) {
Review Comment:
note that this was actually a bug becuase this method always sets the
`pageNumber` to `MemoryBlock.FREED_IN_TMM_PAGE_NUMBER` but was only checking
for `MemoryBlock.FREED_IN_ALLOCATOR_PAGE_NUMBER`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
