alamb opened a new pull request, #17127: URL: https://github.com/apache/datafusion/pull/17127
## Which issue does this PR close? - Follow on to https://github.com/apache/datafusion/pull/17022 - part of https://github.com/apache/datafusion/issues/17000 ## Rationale for this change As suggested by @nuno-faria here: https://github.com/apache/datafusion/pull/17022#discussion_r2264870730 The number of options and flags that are being passed around to the various metadata handling function in the parquet code is getting somewhat out of hand For example in https://github.com/apache/datafusion/pull/17022 from @shehabgamin a significant portion of the PR is adding new options to existing functions to thread through the new options and the tests. If we had this code organized better it would be easier to maintain and extend. Also, as we use the caching more it is important to ensure it is used in all the right places. ## What changes are included in this PR? Proposal: 1. Extract the options into a struct `DFParquetMetadata` 2. Deprecate the old functions 3. Update the functions / tests to create the struct ## Are these changes tested? yes, it is all covered by existing unit tests (changed in this PR) ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
