BlakeOrth commented on code in PR #17127:
URL: https://github.com/apache/datafusion/pull/17127#discussion_r2268090521
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -256,44 +258,19 @@ impl AsyncFileReader for CachedParquetFileReader {
#[cfg(not(feature = "parquet_encryption"))]
let file_decryption_properties = None;
- fetch_parquet_metadata(
- &mut self.inner,
- &file_meta.object_meta,
- None,
- file_decryption_properties,
- Some(metadata_cache),
- )
- .await
- .map_err(|e| {
- parquet::errors::ParquetError::General(format!(
- "Failed to fetch metadata for file {}: {e}",
- file_meta.object_meta.location,
- ))
- })
+ // TODO should there be metadata prefetch hint here?
Review Comment:
From a user's perspective, I think it makes sense that the metadata prefetch
option should apply everywhere metadata is fetched. It can be quite confusing
when you change an option and either see no change at all (positive, negative,
system resource usage etc.), or perhaps even worse, inconsistent change based
on a specific workflow (e.g. "Why do queries for table X use twice the network
hops, but table Y uses 50% more bandwidth?")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
