alamb commented on code in PR #17022:
URL: https://github.com/apache/datafusion/pull/17022#discussion_r2267736239
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -1033,24 +1038,62 @@ impl MetadataFetch for ObjectStoreFetch<'_> {
/// through [`ParquetFileReaderFactory`].
///
/// [`ParquetFileReaderFactory`]: crate::ParquetFileReaderFactory
-pub async fn fetch_parquet_metadata(
- store: &dyn ObjectStore,
- meta: &ObjectMeta,
+pub async fn fetch_parquet_metadata<F: MetadataFetch>(
Review Comment:
I bashed out a PR that pulled the metadata handling out into its own module
and I think it looks quite a big nicer. Thank you for the suggestion
@nuno-faria
- https://github.com/apache/datafusion/pull/17127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
