adriangb commented on code in PR #17132: URL: https://github.com/apache/datafusion/pull/17132#discussion_r2268084291
########## dev/release/README.md: ########## @@ -128,6 +128,15 @@ release. See [#9697](https://github.com/apache/datafusion/pull/9697) for an example. +Modify `asf.yaml` to protect future release candidate branch to prevent accidental merges: + +```yaml +# needs to be updated as part of the release process +branch-50: Review Comment: I think hardcoding with a comment stating why we do that is reasonable. We can also do 10 or 15 years which IMO is probably enough, 100 is overkill. ########## dev/release/README.md: ########## @@ -36,8 +36,8 @@ If you would like to propose your change for inclusion in a release branch for a patch release: 1. Find (or create) the issue for the incremental release ([example release issue]) and discuss the proposed change there with the maintainers. -1. Follow normal workflow to create PR to `main` branch and wait for its approval and merge. -1. After PR is squash merged to `main`, branch from most recent release branch (e.g. `branch-37`), cherry-pick the commit and create a PR targeting the release branch [example backport PR]. +2. Follow normal workflow to create PR to `main` branch and wait for its approval and merge. +3. After PR is squash merged to `main`, branch from most recent release branch (e.g. `branch-37`), cherry-pick the commit and create a PR targeting the release branch [example backport PR]. Review Comment: Curious why this update? Most markdown rendering engines will auto-number if you use the existing approach. E.g. when viewed on GitHub the existing version is correctly numbered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
