jonathanc-n commented on code in PR #17133:
URL: https://github.com/apache/datafusion/pull/17133#discussion_r2268582460
##########
datafusion/execution/src/cache/cache_manager.rs:
##########
@@ -110,7 +145,7 @@ impl CacheManager {
self.file_statistic_cache.clone()
}
- /// Get the cache of objectMeta under same path.
+ /// Get the cache for storing the result of listing ObjectMetas under the
same path.
Review Comment:
```suggestion
/// Get the cache for storing the result of listing [`ObjectMeta`]s
under the same path.
```
##########
datafusion/execution/src/cache/cache_manager.rs:
##########
@@ -24,27 +24,55 @@ use std::any::Any;
use std::fmt::{Debug, Formatter};
use std::sync::Arc;
-/// The cache of listing files statistics.
-/// if set [`CacheManagerConfig::with_files_statistics_cache`]
-/// Will avoid infer same file statistics repeatedly during the session
lifetime,
-/// this cache will store in [`crate::runtime_env::RuntimeEnv`].
+/// A cache for [`Statistics`].
+///
+/// If enabled via [`CacheManagerConfig::with_files_statistics_cache`] this
+/// cache avoids inferring the same file statistics repeatedly during the
+/// session lifetime.
+///
+/// See [`crate::runtime_env::RuntimeEnv`] for more details
pub type FileStatisticsCache =
Arc<dyn CacheAccessor<Path, Arc<Statistics>, Extra = ObjectMeta>>;
+/// Cache for storing the [`ObjectMeta`]s that result from listing a path
+///
+/// Listing a path means doing an object store "list" operation or `ls`
Review Comment:
```suggestion
/// Listing a path means doing an object store "list" operation or `ls`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
