adriangb commented on code in PR #17201:
URL: https://github.com/apache/datafusion/pull/17201#discussion_r2279613226
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -804,8 +805,8 @@ impl ExecutionPlan for HashJoinExec {
self.mode,
self.null_equality,
)?;
- // Preserve the dynamic filter if it exists
- new_join.dynamic_filter = Arc::clone(&self.dynamic_filter);
+ // Create a new dynamic filter with swapped keys after inputs are
swapped
+ new_join.dynamic_filter = Self::create_dynamic_filter(&new_join.on);
Ok(Arc::new(new_join))
Review Comment:
@xudong963 you inspired me to see if I could take a completely different
approach: e7c5d1614
I actually think this approach should also work for and simplify things in
`SortExec` and other places. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
