alamb commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2286420285
##########
datafusion/sql/src/expr/substring.rs:
##########
@@ -77,8 +78,16 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
}
- not_impl_err!(
- "Substring not supported by UserDefinedExtensionPlanners:
{substring_args:?}"
- )
+ let fun = self
Review Comment:
I spent some time debugging and I think the solution is that we needed to
register the appropriate planner with the tests. I pushed a commit here:
e46e5322b81c33883ed79dfeac89e0a5dd8382dc
Note I also found the name of the extension planner very confusing, and I
will make a separate PR to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
