alamb commented on code in PR #17247:
URL: https://github.com/apache/datafusion/pull/17247#discussion_r2286466635
##########
datafusion/core/src/execution/session_state_defaults.rs:
##########
@@ -90,11 +90,10 @@ impl SessionStateDefaults {
Arc::new(functions_nested::planner::NestedFunctionPlanner),
#[cfg(feature = "nested_expressions")]
Arc::new(functions_nested::planner::FieldAccessPlanner),
- #[cfg(any(
- feature = "datetime_expressions",
- feature = "unicode_expressions"
- ))]
- Arc::new(functions::planner::UserDefinedFunctionPlanner),
Review Comment:
for some reason both datetime and unicode expressions were in the same
planner, which is not the same pattern for the other features 🤷 -- so I
propose making main follow the existing pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
