Jefffrey opened a new pull request, #17255:
URL: https://github.com/apache/datafusion/pull/17255
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Relates to #2408
- Decimal support not included so can't close issue yet
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Building on old PR #15413, to get it over the line. Opened as new PR as
other PR was too old and wasn't sure if should push to the original author
branch; for now pushed to my own branch but preserved the original commits.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
From original PR:
1. mv `DistinctSumAccumulator` to common so that it can be used in
`Float64DistinctAvgAccumulator`
2. implement `Float64DistinctAvgAccumulator` using `DistinctSumAccumulator`
3. tested in `aggregate.slt`
Additional changes made by me:
- Fixed error `query error DataFusion error: Arrow error: Invalid argument
error: number of columns\(1\) must match number of fields\(2\) in schema`
(https://github.com/apache/datafusion/pull/15413#issuecomment-2779088360) which
was caused by wrong state fields
- Update the SLT test cases (removed the decimal test cases as those aren't
relevant for this float PR)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added SLT tests, and also regenerated the extended tests (TODO: link PR)
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
TODO: need to check if we explicitly documented about `avg(distinct)` in SQL
documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
