kosiew commented on code in PR #17253:
URL: https://github.com/apache/datafusion/pull/17253#discussion_r2287576119
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2876,6 +2884,25 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn test_aggregate_count_all_with_alias() -> Result<()> {
Review Comment:
Current regression test checks the physical plan schema but not final
DataFrame output.
What do you think about adding a DataFrame-level test for `count_all`
aliasing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
