Loaki07 commented on PR #17253:
URL: https://github.com/apache/datafusion/pull/17253#issuecomment-3213385568

   > hi @Loaki07 ,
   > 
   > Merging this PR will make these changes:
   > 
   > ```
   >  datafusion-testing                                 |  1 -
   >  datafusion/core/src/physical_planner.rs            | 39 
++++++++++++++++++----
   >  .../core/tests/dataframe/dataframe_functions.rs    | 25 ++++++++++++++
   >  3 files changed, 58 insertions(+), 7 deletions(-)
   > ```
   > 
   > ie it will delete `datafusion-testing` in the main branch which will cause 
many tests to fail.
   > 
   > Please run `git submodule add -f 
https://github.com/apache/datafusion-testing.git datafusion-testing` and push 
the PR again.
   > 
   > The PR should only contain these changes:
   > 
   > ```
   >  datafusion/core/src/physical_planner.rs            | 39 
++++++++++++++++++----
   >  .../core/tests/dataframe/dataframe_functions.rs    | 25 ++++++++++++++
   >  2 files changed, 58 insertions(+), 6 deletions(-)
   > ```
   
   yeah, could you please check now 
   Its still shows up as fie changed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to