Jefffrey commented on code in PR #17264: URL: https://github.com/apache/datafusion/pull/17264#discussion_r2289912363
########## datafusion/expr-common/src/signature.rs: ########## @@ -44,42 +43,79 @@ pub const TIMEZONE_WILDCARD: &str = "+TZ"; /// valid length. It exists to avoid the need to enumerate all possible fixed size list lengths. pub const FIXED_SIZE_LIST_WILDCARD: i32 = i32::MIN; -/// A function's volatility, which defines the functions eligibility for certain optimizations +/// When a function's output changes when the input does not +/// +/// The volatility of a function determine eligibility for certain +/// optimizations. You should always defined your function to have the strictest +/// volatility that applies to it to maximize performance and avoid unexpected +/// results. Review Comment: ```suggestion /// How a function's output changes with respect to a fixed input /// /// The volatility of a function determines eligibility for certain /// optimizations. You should always define your function to have the strictest /// possible volatility to maximize performance and avoid unexpected /// results. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
