timsaucer commented on code in PR #16969:
URL: https://github.com/apache/datafusion/pull/16969#discussion_r2312442390
##########
datafusion/functions/src/string/common.rs:
##########
@@ -342,6 +344,25 @@ where
Ok(ColumnarValue::Array(Arc::new(string_builder.finish())))
}
+ DataType::RunEndEncoded(run_index, value_index) => {
+ if value_index.data_type() == &DataType::Utf8 {
+ case_conversion_run_array::<i32, _>(
+ array,
+ op,
+ name,
+ &run_index.data_type(),
+ )
+ } else if value_index.data_type() == &DataType::LargeUtf8 {
Review Comment:
What about Utf8View? As I'm thinking about it, it doesn't seem to make sense
to have a REE with value data type of Utf8View. I haven't dug deep enough to
verify this though. I ask mostly for my own understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
