mbutrovich commented on code in PR #2268:
URL: https://github.com/apache/datafusion-comet/pull/2268#discussion_r2316249628
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -89,6 +91,7 @@ impl ScanExec {
input_source: Option<Arc<GlobalRef>>,
input_source_description: &str,
data_types: Vec<DataType>,
+ arrow_ffi_safe: bool,
Review Comment:
Playing devil's advocate for the "prefer enums over booleans" argument: do
we think we would ever want more granularity for FFI/buffer behavior than
"safe" vs. "not safe?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
