adriangb commented on code in PR #17398:
URL: https://github.com/apache/datafusion/pull/17398#discussion_r2322315202
##########
datafusion/core/tests/physical_optimizer/limit_pushdown.rs:
##########
@@ -52,9 +52,18 @@ fn projection_exec(
) -> Result<Arc<dyn ExecutionPlan>> {
Ok(Arc::new(ProjectionExec::try_new(
vec![
- (col("c1", schema.as_ref()).unwrap(), "c1".to_string()),
- (col("c2", schema.as_ref()).unwrap(), "c2".to_string()),
- (col("c3", schema.as_ref()).unwrap(), "c3".to_string()),
+ ProjectionExpr {
Review Comment:
Nice yeah I was thinking of doing that but thought it best to update our
internal tests anyway.
The unfortunate part is that there's no way to mark an implementation as
deprecated: ideally we'd allow this for a couple releases then remove it to
simplify things, but that's not possible. I guess we keep it around forever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
