rkrishn7 commented on code in PR #17371:
URL: https://github.com/apache/datafusion/pull/17371#discussion_r2323274666
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -837,7 +842,6 @@ impl ExecutionPlan for HashJoinExec {
)?,
// Keep the dynamic filter, bounds accumulator will be reset
dynamic_filter: self.dynamic_filter.clone(),
Review Comment:
Since it's possible that subsequent optimization rules can break reference
integrity, does it make sense to preserve this unconditionally?
Maybe we can an additional check and see if the dynamic filter is preserved
on the incoming right child?
I wonder if in any case we can reset the bounds accumulator to
`OnceLock::new()` since it's lazily initialized during `execute()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
