adriangb commented on code in PR #17371:
URL: https://github.com/apache/datafusion/pull/17371#discussion_r2323370782
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -837,7 +842,6 @@ impl ExecutionPlan for HashJoinExec {
)?,
// Keep the dynamic filter, bounds accumulator will be reset
dynamic_filter: self.dynamic_filter.clone(),
Review Comment:
Maybe it would be reasonable to always call
`DynamicFilterPhysicalExpr::update(lit(true))` from
`ExecutionPlan::with_new_children` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
