kazuyukitanimura commented on code in PR #2385:
URL: https://github.com/apache/datafusion-comet/pull/2385#discussion_r2342621660
##########
spark/src/test/scala/org/apache/comet/CometStringExpressionSuite.scala:
##########
@@ -103,12 +103,7 @@ class CometStringExpressionSuite extends CometTestBase {
s"insert into $table values(1, 'james smith'), (2, 'michael rose'), " +
"(3, 'robert williams'), (4, 'rames rose'), (5, 'james smith'), " +
"(6, 'robert rose-smith'), (7, 'james ähtäri')")
- if (CometConf.COMET_EXEC_INITCAP_ENABLED.get()) {
- // TODO: remove this if clause
https://github.com/apache/datafusion-comet/issues/1052
- checkSparkAnswerAndOperator(s"SELECT initcap(name) FROM $table")
- } else {
- checkSparkAnswer(s"SELECT initcap(name) FROM $table")
- }
+ checkSparkAnswer(s"SELECT initcap(name) FROM $table")
Review Comment:
Is https://github.com/apache/datafusion-comet/issues/1052
resolved?
If so we should use `checkSparkAnswerAndOperator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
