parthchandra commented on code in PR #2379:
URL: https://github.com/apache/datafusion-comet/pull/2379#discussion_r2349832684
##########
common/src/main/java/org/apache/comet/NativeBase.java:
##########
@@ -153,18 +154,25 @@ private static void bundleLoadLibrary() {
private static void initWithLogConf() {
String logConfPath = System.getProperty(LOG_CONF_PATH(),
Utils.getConfPath(LOG_CONF_NAME()));
+ String logLevel = System.getenv(LOG_LEVEL_ENV());
// If both the system property and the environmental variable failed to
find a log
// configuration, then fall back to using the deployed default
if (logConfPath == null) {
LOG.info(
"Couldn't locate log file from either COMET_CONF_DIR or
comet.log.file.path. "
- + "Using default log configuration which emits to stdout");
+ + "Using default log configuration with {} log level which emits
to stderr",
Review Comment:
Why change to stderr? Shouldn't the default log level should be info,
emitting to stdout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
