bvolpato opened a new pull request, #17604:
URL: https://github.com/apache/datafusion/pull/17604

   
   ## Which issue does this PR close?
   
   - Very small addition to the Substrait logical plan conversion, now that 
they have proper RIGHT_ANTI and RIGHT_SEMI join types: 
https://github.com/substrait-io/substrait/pull/662
   
   - Closes #17603.
   
   ## Rationale for this change
   
   - Even when not used explicitly, certain shapes of queries (WHERE `NOT 
EXISTS (SELECT 1 FROM ...)`) would get rewritten/optimized as left-anti joins, 
so this is a bit more problematic than just not supporting the conversions.
    
   ## What changes are included in this PR?
   
   Just the necessary mapping for the consumer/producer, and the tests to 
validate the new join types.
   
   (+1 for `RightSemi Join` which was also a blind spot.)
   
   
   ## Are these changes tested?
   
   Added proper unit tests.
   
   ## Are there any user-facing changes?
   
   n/a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to