Jefffrey commented on code in PR #17657: URL: https://github.com/apache/datafusion/pull/17657#discussion_r2362578966
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -2423,6 +2423,20 @@ select array_sort(make_array(1, 3, null, 5, NULL, -5)), array_sort(make_array(1, ---- [NULL, NULL, -5, 1, 3, 5] [NULL, 1, 2, 3] [NULL, 3, 2, 1] +query ??? +select array_sort(arrow_cast(make_array(1, 3, null, 5, NULL, -5), 'LargeList(Int64)')), + array_sort(arrow_cast(make_array(1, 3, null, 2), 'LargeList(Int64)'), 'ASC'), + array_sort(arrow_cast(make_array(1, 3, null, 2), 'LargeList(Int64)'), 'desc', 'NULLS FIRST'); +---- +[NULL, NULL, -5, 1, 3, 5] [NULL, 1, 2, 3] [NULL, 3, 2, 1] + +query ??? Review Comment: Yep, the signature specifies coercion from fixed size list to list (existing behaviour, just adding tests since I didn't spot any for fixed size lists) https://github.com/apache/datafusion/blob/ac42765ec1ddd80dbb047ed005891577532cbaaa/datafusion/functions-nested/src/sort.rs#L96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
