findepi commented on code in PR #17643:
URL: https://github.com/apache/datafusion/pull/17643#discussion_r2363330181
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1070,16 +1070,27 @@ fn format_simple_data_type(data_type: &DataType) ->
String {
impl From<DFSchema> for Schema {
/// Convert DFSchema into a Schema
fn from(df_schema: DFSchema) -> Self {
- let fields: Fields = df_schema.inner.fields.clone();
- Schema::new_with_metadata(fields, df_schema.inner.metadata.clone())
+ (&df_schema).into()
}
}
impl From<&DFSchema> for Schema {
/// Convert DFSchema reference into a Schema
fn from(df_schema: &DFSchema) -> Self {
- let fields: Fields = df_schema.inner.fields.clone();
- Schema::new_with_metadata(fields, df_schema.inner.metadata.clone())
+ df_schema.as_arrow().clone()
+ }
+}
+
+impl<'a> From<&'a DFSchema> for &'a Schema {
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
