Re: [PR] Prevent exponential planning time for Window functions [datafusion]

[via GitHub]

findepi commented on code in PR #17563:
URL: https://github.com/apache/datafusion/pull/17563#discussion_r2355682425


##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -636,7 +636,8 @@ pub fn get_window_mode(
 
 fn sort_options_resolving_constant(expr: Arc<dyn PhysicalExpr>) -> 
Vec<PhysicalSortExpr> {
     vec![
-        PhysicalSortExpr::new(Arc::clone(&expr), SortOptions::new(false, 
false)),
+        // TODO restore while avoiding exponential planning time

Review Comment:
   filed and added link to 
   - https://github.com/apache/datafusion/issues/17624



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org