Jefffrey commented on PR #16483: URL: https://github.com/apache/datafusion/pull/16483#issuecomment-3315506735
> Hm, interestingly, the speedup is not higher than I expected... I assume there may be some inconsistencies in benchmark code, I have experience only with JMH, so, I may miss something here. /cc @Dandandan > > Benchmark results: > > ``` > Benchmarking compute_hex_new: Warming up for 3.0000 s > Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.1s, or reduce sample count to 90. > compute_hex_new time: [49.225 ms 49.905 ms 50.779 ms] > Found 8 outliers among 100 measurements (8.00%) > 2 (2.00%) high mild > 6 (6.00%) high severe > > Benchmarking compute_hex_old: Warming up for 3.0000 s > Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.0s, or reduce sample count to 90. > compute_hex_old time: [50.322 ms 50.565 ms 50.820 ms] > Found 3 outliers among 100 measurements (3.00%) > 3 (3.00%) high mild > ``` > > Hardware: MBP m3 pro > > Benchmark code: @Fly-Style I think you should be benchmarking raw Int64Arrays instead of DictionaryArrays 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
