HeWhoHeWho commented on code in PR #1242:
URL:
https://github.com/apache/datafusion-python/pull/1242#discussion_r2366243776
##########
python/datafusion/dataframe.py:
##########
@@ -415,7 +415,14 @@ def drop(self, *columns: str) -> DataFrame:
Returns:
DataFrame with those columns removed in the projection.
"""
Review Comment:
> If people want the behavior of `select` and `sort` changed then we should
consider adding an upstream change to the `datafusion` repo with a
configuration setting to do this. I tested with the
`datafusion.sql_parser.enable_ident_normalization` but that didn't seem to make
an impact.
Say we go by - if Expression is used, then force the usage of double quote,
otherwise allow `select('col')` or `select('"col"')`, same goes for sort.
Would this be a big change on upstream at datafusion repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
