Re: [I] The config values aren't checked [datafusion]

[via GitHub]

2010YOUY01 commented on issue #17498:
URL: https://github.com/apache/datafusion/issues/17498#issuecomment-3316072477

   > Hey [@xudong963](https://github.com/xudong963) 
[@Weijun-H](https://github.com/Weijun-H)
   > 
   > I was not able to reproduce this issue with the latest build:
   > 
   > <img alt="Image" width="1012" height="165" 
src="https://private-user-images.githubusercontent.com/3762201/491660610-a137a21b-c3d0-4d07-863c-32e8e46d903a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTg0NjkxNzEsIm5iZiI6MTc1ODQ2ODg3MSwicGF0aCI6Ii8zNzYyMjAxLzQ5MTY2MDYxMC1hMTM3YTIxYi1jM2QwLTRkMDctODYzYy0zMmU4ZTQ2ZDkwM2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDkyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA5MjFUMTUzNDMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjQxMzQyNWI3NjdhMTdkMDY0MWNlOTk1NzljOGYyYmM2MTk2NWQxNDNmZjJlMjU0ZWVlYzVhZmQ3ZDI5N2RmNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.sDesjk444d40HhIEl3AGtOtDzP9KIdfm-LlVi_tVpAY";>
   > What do you think if some more improvements are required?
   > 
   > P.S. I did some digging and found that 
[suggest_valid_function](https://github.com/apache/datafusion/blob/b9517a1a08c573af2ee0e8814413eb5d96b2e5bd/datafusion/sql/src/expr/function.rs#L40)
 is already available. So a potential improvement could be something like "did 
you mean" suggestions.
   
   I think 'did you mean' is a good idea too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org