kosiew commented on code in PR #1243:
URL:
https://github.com/apache/datafusion-python/pull/1243#discussion_r2366547800
##########
docs/source/conf.py:
##########
@@ -94,6 +97,10 @@ def autoapi_skip_member_fn(app, what, name, obj, skip,
options) -> bool: # noqa
if (what, name) in skip_contents:
skip = True
+ # Skip private members that start with underscore to avoid duplication
+ if name.split(".")[-1].startswith("_") and what in ("data", "variable"):
+ skip = True
+
Review Comment:
- The explicit skip_contents list handles targeted, known problem cases
(re-exports, specific deprecated APIs, or particular items that cause
duplication or confusion). It’s precise and intentional.
- The private-name filter is a broad rule to remove many small
implementation details (module-level private constants) without listing them
all manually. This prevents the docs from listing every private variable.
I'll also add clarifying comments in autoapi_skip_member_fn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
