LucaCappelletti94 commented on PR #2037: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2037#issuecomment-3327524804
Regarding commit [c893bda](https://github.com/apache/datafusion-sqlparser-rs/pull/2037/commits/c893bda671a2dcf90cb0b7c22270782bcaaaa5fa), it should be noted that the `MsSQL` parser for triggers is incorrect, as it does not include [much of their syntax](https://learn.microsoft.com/en-us/sql/t-sql/statements/create-trigger-transact-sql?view=sql-server-ver17), and currently always adds in a `FOR STATEMENT`, which is incorrect. This is clearly way outside the current PR objectives though. I have patched the parse trigger so that it would be compatible with the `MsSQL` tests, but I am completely unfamiliar with that dialect so I would leave a more refined extension to somebody more familiar with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
