LucaCappelletti94 commented on PR #2037: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2037#issuecomment-3381061328
> @LucaCappelletti94 [the link](https://github.com/apache/datafusion-sqlparser-rs/pull/2037#discussion_r2379300179) takes me to the top of the page not sure why but I'm unable to find the comment in this case Here follows the comment: > So, if you mean to refactor this into: > > ```rust > } else { > None > }; > ``` > > would simply make it more permissive and allow for parsing stuff that does not make sense in some dialects. > > Conversely, the following: > > ```rust > } else { > self.expect_keyword_is(Keyword::FOR)?; > > None > }; > ``` > > would crash for valid SQLite statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
